DOC - WIP: try to fix time comparison, but could not find root cause #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of the PR
Timing comparison with scikit-leran for Lasso is wrong and presents skglm in a bad light. Potential reasons are warmups, but root cause could not be identified yet.
( Closes issue #302 )
Contributions of the PR
WIP: Debug, interestingly the graphs appear correct if run in Jupyter Notebook instead of a python script, which underlines the assumption that something regarding warm-up / compilation time does not quite work correct.
Checks before merging PR